Move login details validation to provider #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adammw
force-pushed
the
adammw/provider-validate
branch
3 times, most recently
from
69d55dc
to
570e708
Compare
adammw
force-pushed
the
adammw/provider-validate
branch
from
570e708
to
117b9ca
Compare
|
cc @wolfeidau |
|
Going to test this out a bit, I LOVE the idea of making it more pluggable though, there are a few places where complexity has grown with the number of providers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally got sick of having to put a dummy password in to saml2aws when using the shell provider, so moving the validate into the provider so they can be different. Not sure how it interacts with iDP validate method or how they're different...