Move common.comparison to monitoring.comparison (#2318)

* Move comparison from common to monitoring

* Update import paths

client/verta/tests/monitoring/alerts/test_alerter.py

@@ -11,7 +11,7 @@
     RangeAlerter,
     ReferenceAlerter,
 )
-from verta.common.comparison import _VertaComparison
+from verta.monitoring.comparison import _VertaComparison
 
 
 class TestFixed:

client/verta/tests/monitoring/alerts/test_entities.py

@@ -8,7 +8,7 @@
     _utils,
     time_utils,
 )
-from verta.common import comparison
+from verta.monitoring import comparison
 from verta.monitoring.alert import (
     FixedAlerter,
     RangeAlerter,

client/verta/tests/common/comparison/test_comparison.py → client/verta/tests/monitoring/comparison/test_comparison.py

@@ -7,7 +7,7 @@
 import hypothesis.strategies as st
 
 from verta._protos.public.common import CommonService_pb2 as _CommonService
-from verta.common.comparison import (
+from verta.monitoring.comparison import (
     _VertaComparison,
     EqualTo,
     NotEqualTo,

client/verta/verta/monitoring/alert/_alerter.py

@@ -5,7 +5,7 @@
 from verta.external import six
 
 from verta._protos.public.monitoring import Alert_pb2 as _AlertService
-from verta.common import comparison as comparison_module
+from verta.monitoring import comparison as comparison_module
 from verta.monitoring import utils
 
 
@@ -54,7 +54,7 @@ def _from_proto(cls, msg):
     def _validate_comparison(comparison):
         if not isinstance(comparison, comparison_module._VertaComparison):
             raise TypeError(
-                "`comparison` must be an object from verta.common.comparison,"
+                "`comparison` must be an object from verta.monitoring.comparison,"
                 " not {}".format(type(comparison))
             )
         return comparison
@@ -71,15 +71,15 @@ class FixedAlerter(_Alerter):
 
     Parameters
     ----------
-    comparison : :class:`~verta.common.comparison._VertaComparison`
+    comparison : :mod:`~verta.monitoring.comparison`
         Alert condition. An alert is active if a queried sample meets this
         condition.
 
     Examples
     --------
     .. code-block:: python
 
-        from verta.common.comparison import GreaterThan
+        from verta.monitoring.comparison import GreaterThan
         from verta.monitoring.alert import FixedAlerter
 
         alerter = FixedAlerter(GreaterThan(.7))
@@ -132,7 +132,7 @@ class ReferenceAlerter(_Alerter):
 
     Parameters
     ----------
-    comparison : :class:`~verta.common.comparison._VertaComparison`
+    comparison : :mod:`~verta.monitoring.comparison`
         Alert condition. An alert is active if the distance between a queried
         sample and `reference_sample` meets this condition.
     reference_sample : :class:`~verta.monitoring.summaries.SummarySample`
@@ -143,7 +143,7 @@ class ReferenceAlerter(_Alerter):
     .. code-block:: python
 
         from verta import Client
-        from verta.common.comparison import GreaterThan
+        from verta.monitoring.comparison import GreaterThan
         from verta.monitoring.alert import ReferenceAlerter
         from verta.monitoring.summaries import SummarySampleQuery
 

client/verta/verta/common/comparison/_equal_to.py → client/verta/verta/monitoring/comparison/_equal_to.py

@@ -18,7 +18,7 @@ class EqualTo(_VertaComparison):
     --------
     .. code-block:: python
 
-        from verta.common.comparison import EqualTo
+        from verta.monitoring.comparison import EqualTo
         assert EqualTo(.5).compare(.5)
 
     """

client/verta/verta/common/comparison/_greater_than.py → client/verta/verta/monitoring/comparison/_greater_than.py

@@ -18,7 +18,7 @@ class GreaterThan(_VertaComparison):
     --------
     .. code-block:: python
 
-        from verta.common.comparison import GreaterThan
+        from verta.monitoring.comparison import GreaterThan
         assert GreaterThan(.7).compare(.9)
 
     """

client/verta/verta/common/comparison/_greater_than_or_equal_to.py → client/verta/verta/monitoring/comparison/_greater_than_or_equal_to.py

@@ -18,7 +18,7 @@ class GreaterThanOrEqualTo(_VertaComparison):
     --------
     .. code-block:: python
 
-        from verta.common.comparison import GreaterThanOrEqualTo
+        from verta.monitoring.comparison import GreaterThanOrEqualTo
         assert GreaterThanOrEqualTo(.7).compare(.9)
 
     """

client/verta/verta/common/comparison/_less_than.py → client/verta/verta/monitoring/comparison/_less_than.py

@@ -18,7 +18,7 @@ class LessThan(_VertaComparison):
     --------
     .. code-block:: python
 
-        from verta.common.comparison import LessThan
+        from verta.monitoring.comparison import LessThan
         assert LessThan(.3).compare(.1)
 
     """

client/verta/verta/common/comparison/_less_than_or_equal_to.py → client/verta/verta/monitoring/comparison/_less_than_or_equal_to.py

@@ -18,7 +18,7 @@ class LessThanOrEqualTo(_VertaComparison):
     --------
     .. code-block:: python
 
-        from verta.common.comparison import LessThanOrEqualTo
+        from verta.monitoring.comparison import LessThanOrEqualTo
         assert LessThanOrEqualTo(.3).compare(.1)
 
     """

client/verta/verta/common/comparison/_not_equal_to.py → client/verta/verta/monitoring/comparison/_not_equal_to.py

@@ -18,7 +18,7 @@ class NotEqualTo(_VertaComparison):
     --------
     .. code-block:: python
 
-        from verta.common.comparison import NotEqualTo
+        from verta.monitoring.comparison import NotEqualTo
         assert NotEqualTo(.5).compare(.7)
 
     """