Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow create_version_from_run() to take a run obj #2500

Merged
merged 3 commits into from Jul 21, 2021
Merged

Conversation

convoliution
Copy link
Contributor

Because a method that says from_run() ought to be able to take a run.

Tests

$ pytest test_model_registry/test_model_version.py::TestMDBIntegration::test_from_run
==================================================== test session starts ====================================================
platform darwin -- Python 2.7.18, pytest-4.6.11, py-1.10.0, pluggy-0.13.1
rootdir: /Users/miliu/Documents/modeldb/client/verta/tests, inifile: pytest.ini
plugins: hypothesis-4.57.1
collected 1 item                                                                                                            

test_model_registry/test_model_version.py .                                                                           [100%]

=========================================== 1 passed, 4 warnings in 31.85 seconds ===========================================

@convoliution convoliution merged commit 076d345 into master Jul 21, 2021
@convoliution convoliution deleted the ml/from-run branch July 21, 2021 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants