[VR-12269] Enable alerter to propagate store_aggregate
for finding samples
#2519
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If an alert is defined with
summary_sample_base
fields that aren't explicitly supported by the client, those fields end up getting dropped whenalert.summary_sample_base
is accessed because ofSummarySampleQuery
's implementation.Solution
Rather than have a bunch of explicit conversion logic in
SummarySampleQuery._from_proto_request()
andSummarySampleQuery._to_proto_request()
, I've changedSummarySampleQuery
to transparently carry an protobuf message. I've listed some alternative solutions I considered in a Google Doc linked on the ticket.Tests