[VR-12755] Support logging model versions based on containers #2641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 21, 2021
* Accept model API in log_docker() * Add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact and Context
This adds support for specifying a Docker image to potentially be run as a model.
Linting checks fail until #2637 and #2640 are merged.
Risks
It's new functionality which could introduce its own isolated bugs. A best attempt has been made at test coverage.
Testing
Deployed the service to dev envpytest registry/test_docker_image.pypasses on my machine in Python 2.7 and 3.7.pytest registry/model_version/test_docker.pypasses on my machine in Python 2.7 and 3.7.How to Revert
Revert this PR