Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [VRD-711] Add batch prediction method to client #3645
feat: [VRD-711] Add batch prediction method to client #3645
Changes from 22 commits
8f0b66b
96f4c7a
9a25cac
b27f0b4
c3ff09b
bc102bb
0be35d7
12fd2b4
6e5b26f
596a5fa
93468a5
37a4f5d
83d114e
a58e53a
a856e44
4d9f243
93f4b8a
6d45ee2
e666ffa
6bed084
b59b61f
fa5abd8
6378145
eda87f4
8868050
7bc14ba
cdd5d12
c88594e
bf823f6
a2e9dcb
f271d79
16ac5b5
71e1715
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you cmd-F replace
'
with"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ya
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm I feel like resetting the index conceptually weakens the test (now we can't check index values if we ever wanted to).
assert_frame_equal()
appears to have acheck_index_type
parameter. Would that have worked?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a different tests with indexes, does that change your opinion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried the
check_index_type
and it didn't do enough 😭There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, somewhere along the line, number indexes are converting to string indexes and that's sketchy. I should look into that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume it should be
df
because the tests above use that in variable namesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should remove the header from these tests because it's unrelated haha (unless we do need it??)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is a bit hard to read (and therefore probably hard to main/debug); it's unclear that the
batch_size=1
here forces us to have five batches becauseinput_df
has five rows, and that it's related toexpected_df_list
having five DataFrames.But I don't know how I'd write it any better 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you tell I find-replaced all the single quotes? 😅