Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [VRD-820] Implement Build.date_created #3756

Merged
merged 5 commits into from Apr 25, 2023
Merged

Conversation

liuverta
Copy link
Contributor

@liuverta liuverta commented Apr 20, 2023

Impact and Context

Return datetime object as a new Build.date_created attribute.

Risks and Area of Effect

None; entirely new functionality, covered by tests.

Testing

  • Unit test
  • Deployed to dev env
  • Other (explain)

In Python 3.10:

% pytest unit_tests/deployment/test_build.py 
==================================================== test session starts ====================================================
platform darwin -- Python 3.10.6, pytest-7.2.1, pluggy-1.0.0
rootdir: /Users/miliu/Documents/modeldb/client/verta/tests, configfile: pytest.ini
plugins: forked-1.4.0, xdist-3.1.0, typeguard-2.13.3, hypothesis-6.67.1
collected 2 items                                                                                                           

unit_tests/deployment/test_build.py ..                                                                                [100%]

=============================================== 2 passed, 1 warning in 2.67s ================================================

Reverting

  • Contains Migration - Do Not Revert

Revert this PR.

@liuverta liuverta changed the title feat: Add Build.date_created feat: Add Build.date_created Apr 20, 2023
@liuverta liuverta changed the title feat: Add Build.date_created feat: [VRD-820] Implement Build.date_created Apr 20, 2023
@liuverta liuverta merged commit edc994d into main Apr 25, 2023
7 checks passed
@liuverta liuverta deleted the liu/build-datetime branch April 25, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants