fix: Correct Build Scan Endpoint #3785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuverta
requested changes
May 2, 2023
…rop workspace parameter from expected user inputs
…antiating `Build` objects
…_model_id` for use in tests that now call reqistry and need this parameter
…account for additional API call performed
…` and use mocked workspace name
ewagner-verta
commented
May 2, 2023
ewagner-verta
commented
May 2, 2023
ewagner-verta
commented
May 2, 2023
liuverta
requested changes
May 2, 2023
liuverta
approved these changes
May 3, 2023
Co-authored-by: Liu <96442646+liuverta@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact and Context
Fixes the
Build.start_scan()function to use the correct URL for the endpoint (needs to includeworkspace)Risks and Area of Effect
Low risk, fixes a bug.
Testing
Reverting