Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update set_pii docstring #3839

Merged
merged 3 commits into from May 30, 2023
Merged

docs: Update set_pii docstring #3839

merged 3 commits into from May 30, 2023

Conversation

hmacdonald-verta
Copy link
Contributor

@hmacdonald-verta hmacdonald-verta commented May 30, 2023 •
edited

Impact and Context

Want the docs to include a warning

Risks and Area of Effect

Testing

  • Unit test
  • Deployed to dev env
  • Other (explain)

Screenshot 2023-05-30 at 4 10 17 PM

Reverting

  • Contains Migration - Do Not Revert

@github-actions
Copy link

github-actions bot commented May 30, 2023 •
edited

Common Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 10.79% 🍏

@github-actions
Copy link

Backend Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 33.71% ❌

@hmacdonald-verta hmacdonald-verta marked this pull request as ready for review May 30, 2023 23:10
liuverta
liuverta reviewed May 30, 2023
View reviewed changes
Copy link
Contributor

@liuverta liuverta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh um I totally missed this in the original PR: We should have a Parameters section for set_pii() and Returns for get_pii().

client/verta/verta/registry/entities/_model.py Outdated Show resolved Hide resolved
hmacdonald-verta and others added 2 commits May 30, 2023 16:16
@hmacdonald-verta @liuverta
Update client/verta/verta/registry/entities/_model.py
20dd67f 
Co-authored-by: Liu <96442646+liuverta@users.noreply.github.com>
@hmacdonald-verta
More docs
bdcf8a6
liuverta
liuverta approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@liuverta liuverta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phemonemal

@hmacdonald-verta hmacdonald-verta merged commit 0de74c3 into main May 30, 2023
6 checks passed
@hmacdonald-verta hmacdonald-verta deleted the hm/addPIIWarning branch May 30, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuverta liuverta liuverta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hmacdonald-verta @liuverta