feat: Allow specifying org id in client #3878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Common Code Coverage
|
Backend Code Coverage
|
liuverta
approved these changes
Jun 12, 2023
client/verta/verta/credentials.py
Outdated
| @@ -67,11 +70,12 @@ def headers(self): | |||
| # without underscore, for NGINX support | |||
| # https://www.nginx.com/resources/wiki/start/topics/tutorials/config_pitfalls#missing-disappearing-http-headers | |||
| "developer-key": self.dev_key, | |||
| "organization-id": self.organization_id or "", | |||
There was a problem hiding this comment.
Would it be preferable to do a
if self.organization_id:
headers["organization-id"] = self.organization_idinstead of passing an empty string?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact and Context
This will include the provided value to the
organization-idmetadata header, which will be processed by the backend. The value is optional.Risks and Area of Effect
Testing
Reverting