Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Various fixes for Open API #3947

Merged
merged 5 commits into from Jul 17, 2023
Merged

fix: Various fixes for Open API #3947

merged 5 commits into from Jul 17, 2023

Conversation

hmacdonald-verta
Copy link
Contributor

@hmacdonald-verta hmacdonald-verta commented Jul 17, 2023

Impact and Context

After releasing the first alpha client release, I was able to do e2e testing. Found some issues that I'm resolving here:

  • The artifact key no longer has .json in the name because ERs can't have .s in the artifact key names
  • Failed output verification now throws an error instead of a warning (I wrote a whole ADR for that and forgot to update the code)
  • Removed recwarn from tests now that there's no warnings
  • Marked new client alpha release for the changes
  • Added comment reminding users that they need to update their endpoint after logging a schema.

Risks and Area of Effect

Testing

  • Unit test
  • Deployed to dev env
  • Other (explain)

I looked in the pod to verify that the model_schema file is, in fact, model_schema, not model_schema.json.

Reverting

  • Contains Migration - Do Not Revert

@github-actions
Copy link

Common Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 15.06% 🍏

@github-actions
Copy link

github-actions bot commented Jul 17, 2023

Backend Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 61.32% 🍏

@hmacdonald-verta hmacdonald-verta merged commit 0fe92ca into main Jul 17, 2023
6 checks passed
@hmacdonald-verta hmacdonald-verta deleted the hm/finishUpOpenAPI branch July 17, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants