VR-4525: Retry part uploads on ConnectionErrors #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
convoliution
changed the title
conradoverta
reviewed
Jun 9, 2020
client/verta/verta/client.py
Outdated
| try: | ||
| response = _utils.make_request("PUT", url, self._conn, data=part_stream) | ||
| except requests.ConnectionError: | ||
| time.sleep(10) |
There was a problem hiding this comment.
This seems way too long. Is there any specific reason for this choice?
There was a problem hiding this comment.
No particular reason at all. Should I remove the sleep?
Wanted a bit of backoff delay for connection problems, and 10s seemed small to me in comparison to how long a 64 MB part upload can take.
There was a problem hiding this comment.
Maybe 1s? Consider that the user would have to sit 30s before knowing something is wrong.
conradoverta
approved these changes
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to specifically only catch broken pipes, but unwrapping a
requestsexception is tedious and undocumented! This is how deep I had to go in my investigation:Rather than have a series of
ifs that I can't even justify with docs because there are none, I'm comfortable with retrying on allConnectionErrors for just this presigned URL upload.