Skip to content

Commit

Permalink
Merge branch 'release/3.0.5'
Browse files Browse the repository at this point in the history
  • Loading branch information
sb10 committed Sep 3, 2018
2 parents 9df7d8a + 5c3e9de commit 4ff4a46
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 0 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/) and this
project adheres to [Semantic Versioning](http://semver.org/).


## [3.0.5] - 2018-09-03
### Fixed
- Bad S3 credentials now immediately return an error from NewS3Accessor(),
instead of allowing you to proceed to an un-usable mount.


## [3.0.4] - 2018-08-18
### Fixed
- Critical fix for potential silent errors when reading from an overloaded
Expand Down
7 changes: 7 additions & 0 deletions s3.go
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,13 @@ func NewS3Accessor(config *S3Config) (*S3Accessor, error) {
// minio-go or ceph gets bugfixed to avoid this...
a.client, err = minio.NewV2(host, config.AccessKey, config.SecretKey, secure)
}

// test that the client actually works (credentials are ok?)
_, err = a.ListEntries("/")
if err != nil {
err = fmt.Errorf("could not access S3: %s", err)
}

return a, err
}

Expand Down

0 comments on commit 4ff4a46

Please sign in to comment.