fix(vscode): ensure daemon spawns in shell for Windows compatibility (#…

…1065)
VeryGoodOpenSource · Sep 20, 2023 · d7efe88 · d7efe88
1 parent afc6d8e
commit d7efe88
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/extensions/vscode/src/daemon/dart-frog-daemon.ts b/extensions/vscode/src/daemon/dart-frog-daemon.ts
@@ -142,6 +142,7 @@ export class DartFrogDaemon {
 
     this.process = spawn("dart_frog", ["daemon"], {
       cwd: workingDirectory,
+      shell: true,
     });
     this.process.stdout.on("data", this.stdoutDataListener.bind(this));
 

diff --git a/extensions/vscode/src/test/suite/daemon/dart-frog-daemon.test.ts b/extensions/vscode/src/test/suite/daemon/dart-frog-daemon.test.ts
@@ -49,6 +49,7 @@ suite("DartFrogDaemon", () => {
       childProcessStub.spawn
         .withArgs("dart_frog", ["daemon"], {
           cwd: workingDirectory,
+          shell: true,
         })
         .returns(daemonProcess);
 
@@ -73,6 +74,7 @@ suite("DartFrogDaemon", () => {
       childProcessStub.spawn
         .withArgs("dart_frog", ["daemon"], {
           cwd: workingDirectory,
+          shell: true,
         })
         .returns(daemonProcess);
 
@@ -94,6 +96,7 @@ suite("DartFrogDaemon", () => {
       childProcessStub.spawn
         .withArgs("dart_frog", ["daemon"], {
           cwd: workingDirectory,
+          shell: true,
         })
         .returns(daemonProcess);
 
@@ -125,6 +128,7 @@ suite("DartFrogDaemon", () => {
       childProcessStub.spawn
         .withArgs("dart_frog", ["daemon"], {
           cwd: workingDirectory,
+          shell: true,
         })
         .returns(daemonProcess);
 
@@ -235,6 +239,7 @@ suite("DartFrogDaemon", () => {
       childProcessStub.spawn
         .withArgs("dart_frog", ["daemon"], {
           cwd: workingDirectory,
+          shell: true,
         })
         .returns(daemonProcess);
 
@@ -318,6 +323,7 @@ suite("DartFrogDaemon", () => {
       childProcessStub.spawn
         .withArgs("dart_frog", ["daemon"], {
           cwd: workingDirectory,
+          shell: true,
         })
         .returns(daemonProcess);
 
@@ -351,6 +357,7 @@ suite("DartFrogDaemon", () => {
         childProcessStub.spawn
           .withArgs("dart_frog", ["daemon"], {
             cwd: workingDirectory,
+            shell: true,
           })
           .returns(daemonProcess);