Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vscode): debug session persists on premature application exit #1042

Closed
2 tasks
alestiago opened this issue Sep 14, 2023 · 0 comments · Fixed by #1043
Closed
2 tasks

fix(vscode): debug session persists on premature application exit #1042

alestiago opened this issue Sep 14, 2023 · 0 comments · Fixed by #1043
Assignees
Labels
bug Something isn't working as expected

Comments

@alestiago
Copy link
Contributor

alestiago commented Sep 14, 2023

Description

Currently, the VS Code extension is assuming developer's Dart Frog code is legitimate. However, sometimes the codebase might have errors that will cause the daemon to exit the application without the developer wanting so. For example, importing dart:html (as show in in demo video). In such cases, the debug session requires to be detached.

Steps To Reproduce

  1. Install dependencies (from: extensions/vscode):
npm i 
  1. Start the extension development host (F5):
  2. Open a Dart Frog project route and include an import statement that imports dart:html:
import 'dart:html';
import 'package:dart_frog/dart_frog.dart';

Response onRequest(RequestContext context) {
  return Response(body: 'Welcome to Dart Frog!');
}
  1. Debug the server
  2. See error

Expected Behavior

  • To detach the application on premature application exit
  • To inform the user about the error that causes the premature application exit

Demonstration

CleanShot.2023-09-14.at.07.49.38.mp4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected
Projects
Development

Successfully merging a pull request may close this issue.

1 participant