Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vscode): detach from debug session on premature application exit #1043

Merged
merged 8 commits into from Sep 14, 2023
Merged

fix(vscode): detach from debug session on premature application exit #1043

merged 8 commits into from Sep 14, 2023

Conversation

alestiago
Copy link
Contributor

@alestiago alestiago commented Sep 14, 2023 •
edited

Status

READY

Description

Resolves #1042

Changes:

  • Listen for an application to be deregistered (in case it is premature) and attempts to terminate the debug session (if it exists)

Demonstration

After:

CleanShot.2023-09-14.at.07.56.18.mp4

Before:

CleanShot.2023-09-14.at.07.49.38.mp4

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@alestiago alestiago self-assigned this Sep 14, 2023
@alestiago alestiago marked this pull request as ready for review September 14, 2023 10:24
@alestiago alestiago marked this pull request as draft September 14, 2023 10:25
@alestiago alestiago marked this pull request as ready for review September 14, 2023 11:07
erickzanardo
erickzanardo approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@erickzanardo erickzanardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit, but LGTM already

extensions/vscode/src/test/suite/commands/debug-dev-server.test.ts Show resolved Hide resolved
@alestiago alestiago merged commit c27b05c into main Sep 14, 2023
4 checks passed
@alestiago alestiago deleted the alestiago/vscode-terminate-debug-session branch September 14, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickzanardo erickzanardo erickzanardo approved these changes

@renancaraujo renancaraujo renancaraujo approved these changes

@felangel felangel Awaiting requested review from felangel

@wolfenrain wolfenrain Awaiting requested review from wolfenrain

Assignees

@alestiago alestiago

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(vscode): debug session persists on premature application exit
3 participants
@alestiago @erickzanardo @renancaraujo