Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add gen2 to Google Cloud Run deploy #1191

Merged
merged 11 commits into from Jan 8, 2024

Conversation

ryzizub
Copy link
Contributor

@ryzizub ryzizub commented Dec 12, 2023

There is an issue where container is stuck when generation of cloud run used is gen1. I came across it while working on the connection to the postgres database in the dart frog backend. I would recommend gen2 for cloud run since it's better environment for Dart backends.

Status

READY

Description

Adding extra command to cloud run deploy based on the official documentation

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@ryzizub ryzizub requested a review from a team as a code owner December 12, 2023 21:04
@ryzizub ryzizub changed the title docs: add gen2 to google-cloud-run docs: add gen2 to Google Cloud Run deploy Dec 12, 2023
@alestiago alestiago added the waiting for response Waiting for follow up label Dec 14, 2023
Copy link
Contributor

@alestiago alestiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ryzizub for contributing! Overall it looks good to me 💙 . I left a small comment regarding the styling and positioning of this new documentation.

docs/docs/deploy/google-cloud-run.md Outdated Show resolved Hide resolved
@alestiago alestiago added waiting for response Waiting for follow up and removed waiting for response Waiting for follow up labels Dec 18, 2023
alestiago
alestiago previously approved these changes Dec 21, 2023
Copy link
Contributor

@alestiago alestiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution, LGTM!

docs/docs/deploy/google-cloud-run.md Outdated Show resolved Hide resolved
@wolfenrain wolfenrain merged commit ac4cbf9 into VeryGoodOpenSource:main Jan 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for response Waiting for follow up
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants