refactor(dart_frog_prod_server): simplify and document pubspec.lock fixtures #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alestiago
added
the
refactor
alestiago
changed the title
alestiago
added
the
test
wolfenrain
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Currently the
createExternalPackagesFolderusespubspec.lockfixtures during testing. These fixtures being used are very long and difficult to read and conceptualise what's in them. This Pull Request removes some "transitive" dependencies form the fixtures and documents what the fixture contains. In addition, this simplifies adding dependencies to test specific scenarios as in #1243 .Type of Change