refactor(dart_frog_prod_server): define internal PubspecLock
#1273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alestiago
added
the
refactor
wolfenrain
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Related to #1124.
The
pubspec_lockpackage seems to be no longer maintained. It has an issue alexei-sintotski/pubspec_lock#33, that is causing #1124 . Its community raised a Pull Request alexei-sintotski/pubspec_lock#39 but has not had any activity from its maintainers.We'll be relying on a simplified internal implementation for now. This efforts are mostly being copied from Very Good CLI's implementation.
Note: This is Pull Request is meant to be followed-up by another Pull Request that completely removes the dependency on
pubspec_lock.Type of Change