-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: decouple purity, validity, and submission status #48
refactor!: decouple purity, validity, and submission status #48
Conversation
Codecov Report
@@ Coverage Diff @@
## main #48 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 31 27 -4
=========================================
- Hits 31 27 -4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the simplification! 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank goodness ❤️
Love the changes! Thanks for this! |
Thanks! Yup will try to get a release out shortly. |
Description
This pull request attempts to decouple purity from validity (closes #45) as well as to decouple submission status from validity/purity (closes #46).
Changes
FormzStatus
renamed toFormzSubmissionStatus
:FormzInput
class no longer exposes astatus
(FormzInputStatus
). Instead there areisValid
andisNotValid
getters:FormzInput
has adisplayError
getter which returns an error to display if the input is not valid and has been modified by the user (closes Determining when to show meaningful errors #44)Renamed
pure
toisPure
for consistencyUse
very_good_analysis