fix: support ignoring empty globs (#704)

Co-authored-by: Jochum van der Ploeg <jochum.vanderploeg@verygood.ventures>
VeryGoodOpenSource · Apr 12, 2023 · 6a1a9df · 6a1a9df
1 parent b2ae22b
commit 6a1a9df
Show file tree

Hide file tree

Showing 2 changed files with 51 additions and 1 deletion.
diff --git a/lib/src/cli/cli.dart b/lib/src/cli/cli.dart
@@ -176,7 +176,7 @@ extension _Set on Set<String> {
     if (segments.intersection(this).isNotEmpty) return true;
 
     for (final value in this) {
-      if (Glob(value).matches(entity.path)) {
+      if (value.isNotEmpty && Glob(value).matches(entity.path)) {
         return true;
       }
     }

diff --git a/test/src/commands/packages_test.dart b/test/src/commands/packages_test.dart
@@ -270,6 +270,56 @@ void main() {
         }),
       );
 
+      test(
+        'completes normally '
+        '''when pubspec.yaml exists and directory is not ignored (recursive) with an empty glob''',
+        withRunner((commandRunner, logger, pubUpdater, printLogs) async {
+          final tempDirectory = Directory.systemTemp.createTempSync();
+          final directory = Directory(
+            path.join(tempDirectory.path, 'macos_plugin'),
+          );
+          final pubspecA = File(
+            path.join(directory.path, 'example_a', 'pubspec.yaml'),
+          );
+          final pubspecB = File(
+            path.join(directory.path, 'example_b', 'pubspec.yaml'),
+          );
+          pubspecA
+            ..createSync(recursive: true)
+            ..writeAsStringSync(
+              '''
+          name: example_a
+          version: 0.1.0
+          
+          environment:
+            sdk: ">=2.12.0 <3.0.0"
+          ''',
+            );
+          pubspecB
+            ..createSync(recursive: true)
+            ..writeAsStringSync(
+              '''
+          name: example_b
+          version: 0.1.0
+          
+          environment:
+            sdk: ">=2.12.0 <3.0.0"
+          ''',
+            );
+
+          final result = await commandRunner.run(
+            ['packages', 'get', '--recursive', directory.path, '--ignore=""'],
+          );
+          expect(result, equals(ExitCode.success.code));
+          verify(() {
+            logger.progress(
+              any(that: contains('Running "flutter packages get" in')),
+            );
+          }).called(2);
+          directory.deleteSync(recursive: true);
+        }),
+      );
+
       test(
         'completes normally '
         'when pubspec.yaml exists and directory is ignored (recursive)',