fix(test): report errors without throwing (#393)

VeryGoodOpenSource · May 12, 2022 · 9c1e583 · 9c1e583
1 parent f738a8f
commit 9c1e583
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 10 deletions.
diff --git a/.github/workflows/very_good_cli.yaml b/.github/workflows/very_good_cli.yaml
@@ -39,8 +39,8 @@ jobs:
 
       - name: Run Tests
         run: |
-          flutter pub global activate coverage
-          flutter pub run test -j 1 -x pull-request-only -x e2e --coverage=coverage --test-randomize-ordering-seed random && dart run coverage:format_coverage --lcov --in=coverage --out=coverage/lcov.info --packages=.packages --report-on=lib
+          flutter pub global activate coverage 1.2.0
+          flutter pub run test -j 1 -x pull-request-only -x e2e --coverage=coverage --test-randomize-ordering-seed random && dart pub global run coverage:format_coverage --lcov --in=coverage --out=coverage/lcov.info --packages=.packages --report-on=lib
 
       - name: Check Code Coverage
         uses: VeryGoodOpenSource/very_good_coverage@v1.2.0

diff --git a/lib/src/cli/flutter_cli.dart b/lib/src/cli/flutter_cli.dart
@@ -379,8 +379,8 @@ Future<int> _flutterTest({
       }
     },
     onError: (Object error, StackTrace stackTrace) {
-      subscription.cancel();
-      completer.completeError(error, stackTrace);
+      stderr('$clearLine$error');
+      stderr('$clearLine$stackTrace');
     },
   );
 

diff --git a/test/src/cli/flutter_cli_test.dart b/test/src/cli/flutter_cli_test.dart
@@ -312,7 +312,7 @@ void main() {
         );
       });
 
-      test('throws when process fails (with cleanup)', () async {
+      test('exits with code 69 when process fails (with cleanup)', () async {
         final directory = Directory.systemTemp.createTempSync();
         final testDirectory = Directory(p.join(directory.path, 'test'))
           ..createSync();
@@ -322,22 +322,20 @@ void main() {
             .writeAsStringSync(testContents);
         await expectLater(
           Flutter.test(cwd: directory.path, optimizePerformance: true),
-          throwsA(
-            '''Error: Couldn't resolve the package 'test' in 'package:test/test.dart'.''',
-          ),
+          completion(equals([69])),
         );
         await File(
           p.join(testDirectory.path, '.test_runner.dart'),
         ).ensureDeleted();
       });
 
-      test('throws when there is no test directory', () {
+      test('exits with code 69 when there is no test directory', () {
         final directory = Directory.systemTemp.createTempSync();
         File(p.join(directory.path, 'pubspec.yaml')).writeAsStringSync(pubspec);
 
         expectLater(
           Flutter.test(cwd: directory.path),
-          throwsA('Test directory "test" not found.'),
+          completion(equals([69])),
         );
       });