Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add template for creating a flutter plugin #169

Merged
merged 12 commits into from
Aug 20, 2021
Merged

feat: add template for creating a flutter plugin #169

merged 12 commits into from
Aug 20, 2021

Conversation

denangelov
Copy link
Contributor

Description

feat: add template for creating a flutter plugin

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

felangel
felangel reviewed Aug 19, 2021
View reviewed changes
lib/src/flutter_cli.dart Outdated Show resolved Hide resolved
@felangel felangel added the feature A new feature or request label Aug 19, 2021
@felangel
Copy link
Contributor

@denangelov can we regenerate the bundle using the latest (there were changes made recently)?

felangel
felangel reviewed Aug 20, 2021
View reviewed changes
lib/src/flutter_cli.dart Outdated Show resolved Hide resolved
felangel
felangel reviewed Aug 20, 2021
View reviewed changes
lib/src/flutter_cli.dart Outdated Show resolved Hide resolved
felangel
felangel reviewed Aug 20, 2021
View reviewed changes
Copy link
Contributor

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM! Just left a few minor nits but the main thing is we should regenerate the bundle to incorporate all the recent changes in the plugin brick.

@denangelov
Copy link
Contributor Author

@felangel sounds good will regenerate the bundle in VG cli

felangel
felangel suggested changes Aug 20, 2021
View reviewed changes
Copy link
Contributor

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments.

felangel
felangel approved these changes Aug 20, 2021
View reviewed changes
Copy link
Contributor

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@felangel felangel merged commit 82e2a1d into main Aug 20, 2021
@felangel felangel deleted the add-flutter-plugin branch August 20, 2021 19:32
@felangel felangel mentioned this pull request Aug 20, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felangel felangel felangel approved these changes

@jorgecoca jorgecoca Awaiting requested review from jorgecoca

Assignees

@denangelov denangelov

Labels
feature A new feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denangelov @felangel