Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: include semantic pull request workflow #448

Merged
merged 2 commits into from
Jun 29, 2022
Merged

feat: include semantic pull request workflow #448

merged 2 commits into from
Jun 29, 2022

Conversation

felangel
Copy link
Contributor

Description

  • feat: include semantic pull request workflow
    • very_good_core
    • very_good_dart_cli

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel added the feature A new feature or request label Jun 29, 2022
@felangel felangel self-assigned this Jun 29, 2022
@felangel felangel requested a review from jorgecoca as a code owner June 29, 2022 15:55
renancaraujo
renancaraujo approved these changes Jun 29, 2022
View reviewed changes
lib/src/commands/create/templates/very_good_core/very_good_core_bundle.dart
@@ -1190,37 +1190,37 @@ final veryGoodCoreBundle = MasonBundle.fromJson(<String, dynamic>{
{
"path": "lib/app/app.dart",
"data":
"Ly8gQ29weXJpZ2h0IChjKSAyMDIyLCBWZXJ5IEdvb2QgVmVudHVyZXMKLy8gaHR0cHM6Ly92ZXJ5Z29vZC52ZW50dXJlcwovLwovLyBVc2Ugb2YgdGhpcyBzb3VyY2UgY29kZSBpcyBnb3Zlcm5lZCBieSBhbiBNSVQtc3R5bGUKLy8gbGljZW5zZSB0aGF0IGNhbiBiZSBmb3VuZCBpbiB0aGUgTElDRU5TRSBmaWxlIG9yIGF0Ci8vIGh0dHBzOi8vb3BlbnNvdXJjZS5vcmcvbGljZW5zZXMvTUlULgoKZXhwb3J0ICd2aWV3L2FwcC5kYXJ0JzsK",
"Ly8gQ29weXJpZ2h0IChjKSB7e2N1cnJlbnRfeWVhcn19LCBWZXJ5IEdvb2QgVmVudHVyZXMKLy8gaHR0cHM6Ly92ZXJ5Z29vZC52ZW50dXJlcwovLwovLyBVc2Ugb2YgdGhpcyBzb3VyY2UgY29kZSBpcyBnb3Zlcm5lZCBieSBhbiBNSVQtc3R5bGUKLy8gbGljZW5zZSB0aGF0IGNhbiBiZSBmb3VuZCBpbiB0aGUgTElDRU5TRSBmaWxlIG9yIGF0Ci8vIGh0dHBzOi8vb3BlbnNvdXJjZS5vcmcvbGljZW5zZXMvTUlULgoKZXhwb3J0ICd2aWV3L2FwcC5kYXJ0JzsK",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VGhhdCBsb29rcyBhbGwgcmlnaHQ=

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dGhhbmtzIQ==

lib/src/commands/create/templates/very_good_core/very_good_core_bundle.dart
@@ -14,7 +14,7 @@ final veryGoodCoreBundle = MasonBundle.fromJson(<String, dynamic>{
{
"path": ".github/workflows/main.yaml",
"data":
"bmFtZToge3sjc25ha2VDYXNlfX17e3Byb2plY3RfbmFtZX19e3svc25ha2VDYXNlfX0KCm9uOiBbcHVsbF9yZXF1ZXN0LCBwdXNoXQoKam9iczoKICBidWlsZDoKICAgIHVzZXM6IFZlcnlHb29kT3BlblNvdXJjZS92ZXJ5X2dvb2Rfd29ya2Zsb3dzLy5naXRodWIvd29ya2Zsb3dzL2ZsdXR0ZXJfcGFja2FnZS55bWxAdjEKICAgIHdpdGg6CiAgICAgIGZsdXR0ZXJfY2hhbm5lbDogc3RhYmxlCiAgICAgIGZsdXR0ZXJfdmVyc2lvbjogMy4wLjAK",
"bmFtZToge3sjc25ha2VDYXNlfX17e3Byb2plY3RfbmFtZX19e3svc25ha2VDYXNlfX0KCm9uOiBbcHVsbF9yZXF1ZXN0LCBwdXNoXQoKam9iczoKICBzZW1hbnRpYy1wdWxsLXJlcXVlc3Q6CiAgICB1c2VzOiBWZXJ5R29vZE9wZW5Tb3VyY2UvdmVyeV9nb29kX3dvcmtmbG93cy8uZ2l0aHViL3dvcmtmbG93cy9zZW1hbnRpY19wdWxsX3JlcXVlc3QueW1sQHYxCgogIGJ1aWxkOgogICAgdXNlczogVmVyeUdvb2RPcGVuU291cmNlL3ZlcnlfZ29vZF93b3JrZmxvd3MvLmdpdGh1Yi93b3JrZmxvd3MvZmx1dHRlcl9wYWNrYWdlLnltbEB2MQogICAgd2l0aDoKICAgICAgZmx1dHRlcl9jaGFubmVsOiBzdGFibGUKICAgICAgZmx1dHRlcl92ZXJzaW9uOiAzLjAuMAo=",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VGhhdCBsb29rcyBhbGwgcmlnaHQ=

@felangel felangel merged commit 4b015fb into main Jun 29, 2022
@felangel felangel deleted the feat/include-semantic-pull-request branch June 29, 2022 16:07
@felangel felangel mentioned this pull request Jun 29, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renancaraujo renancaraujo renancaraujo approved these changes

@wolfenrain wolfenrain wolfenrain approved these changes

@erickzanardo erickzanardo Awaiting requested review from erickzanardo

@jorgecoca jorgecoca Awaiting requested review from jorgecoca

Assignees

@felangel felangel

Labels
feature A new feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@felangel @renancaraujo @wolfenrain