Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): groups may not be async #599

Merged
merged 6 commits into from
Dec 9, 2022
Merged

Conversation

wolfenrain
Copy link
Member

Description

Closes #570

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

felangel
felangel previously approved these changes Dec 8, 2022
@felangel
Copy link
Contributor

felangel commented Dec 8, 2022

Can we add a test to prevent regressions?

@wolfenrain
Copy link
Member Author

Can we add a test to prevent regressions?

Yea I was looking into that!

felangel
felangel previously approved these changes Dec 8, 2022
Copy link
Contributor

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

renancaraujo
renancaraujo previously approved these changes Dec 8, 2022
@wolfenrain wolfenrain dismissed stale reviews from renancaraujo and felangel via b27e16a December 9, 2022 13:01
@felangel felangel merged commit cec868c into main Dec 9, 2022
@felangel felangel deleted the fix(test)/groups-may-not-be-async branch December 9, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: very_good test Invalid argument(s): Groups may not be async.
3 participants