Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: recreate flutter create with sub commands #607

Merged
merged 22 commits into from
Jan 6, 2023

Conversation

renancaraujo
Copy link
Contributor

@renancaraujo renancaraujo commented Dec 16, 2022

Description

feat: refactor flutter create with subcommands

Add a common superclass for create subcommands, preserve legacy behavior with a deprecated message

Closes #490
Closes #582
Closes #583

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@renancaraujo renancaraujo force-pushed the feat/add-create-flutter-app-subcommand branch 2 times, most recently from 61c966b to 3f06d85 Compare December 19, 2022 17:55
@renancaraujo renancaraujo force-pushed the feat/add-create-flutter-app-subcommand branch 4 times, most recently from fc21c8e to 1f969e2 Compare January 5, 2023 21:18
@renancaraujo renancaraujo changed the title feat: refactor flutter create with sub commands feat: recreate flutter create with sub commands Jan 5, 2023
@renancaraujo renancaraujo force-pushed the feat/add-create-flutter-app-subcommand branch from 1f969e2 to f40eeb4 Compare January 5, 2023 21:22
@renancaraujo renancaraujo force-pushed the feat/add-create-flutter-app-subcommand branch from 5566fb8 to 7d399d8 Compare January 5, 2023 23:37
@renancaraujo renancaraujo force-pushed the feat/add-create-flutter-app-subcommand branch from 7d399d8 to 4e7c1d8 Compare January 5, 2023 23:45
@renancaraujo renancaraujo marked this pull request as ready for review January 6, 2023 00:01
@renancaraujo renancaraujo force-pushed the feat/add-create-flutter-app-subcommand branch 3 times, most recently from 887d111 to 021950b Compare January 6, 2023 13:34
@renancaraujo renancaraujo force-pushed the feat/add-create-flutter-app-subcommand branch from bbb653d to cb3c1ed Compare January 6, 2023 17:37
felangel
felangel previously approved these changes Jan 6, 2023
Copy link
Contributor

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments but overall LGTM 🎉

Co-authored-by: Felix Angelov <felangelov@gmail.com>
@renancaraujo renancaraujo merged commit e01a127 into main Jan 6, 2023
@renancaraujo renancaraujo deleted the feat/add-create-flutter-app-subcommand branch January 6, 2023 19:28
Copy link
Contributor

@erickzanardo erickzanardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, but LGTM!

return ExitCode.success.code;
}

/// Responsible for returns the template parameters to be passed to the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// Responsible for returns the template parameters to be passed to the
/// Responsible for returning the template parameters to be passed to the

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants