Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create dart cli new usage #612

Merged
merged 5 commits into from
Jan 10, 2023
Merged

feat: create dart cli new usage #612

merged 5 commits into from
Jan 10, 2023

Conversation

renancaraujo
Copy link
Contributor

@renancaraujo renancaraujo commented Jan 6, 2023 •
edited
Loading

Description

closes #585

follows #611

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@renancaraujo renancaraujo linked an issue Jan 6, 2023 that may be closed by this pull request
feat(create)! subcommand: Very Good Dart CLI Usage #585
Closed
felangel
felangel reviewed Jan 6, 2023
View reviewed changes
Copy link
Contributor

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great so far! Will re-review when it's ready 👍

@renancaraujo renancaraujo force-pushed the feat/dart-cli-usage branch 2 times, most recently from a1a4b57 to 6a7ab04 Compare January 9, 2023 11:12
@renancaraujo renancaraujo marked this pull request as ready for review January 9, 2023 11:33
@renancaraujo renancaraujo changed the title feat: dart cli new usage feat: create dart cli new usage Jan 9, 2023
wolfenrain
wolfenrain previously approved these changes Jan 9, 2023
View reviewed changes
lib/src/commands/create/commands/dart_cli.dart Outdated
) {
argParser.addOption(
'executable-name',
help: 'Used by the dart_cli template, the CLI executable name '
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This help needs to be updated

Base automatically changed from feat/dart-pkg-usage to main January 9, 2023 18:05
@renancaraujo renancaraujo merged commit 1a94dc6 into main Jan 10, 2023
@renancaraujo renancaraujo deleted the feat/dart-cli-usage branch January 10, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felangel felangel felangel approved these changes

@wolfenrain wolfenrain wolfenrain approved these changes

@erickzanardo erickzanardo Awaiting requested review from erickzanardo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(create)! subcommand: Very Good Dart CLI Usage
3 participants
@renancaraujo @felangel @wolfenrain