Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for excluding packages #640

Merged
merged 25 commits into from
Mar 7, 2023
Merged

feat: add support for excluding packages #640

merged 25 commits into from
Mar 7, 2023

Conversation

willhlas
Copy link
Contributor

@willhlas willhlas commented Feb 6, 2023 •
edited by wolfenrain
Loading

Description

Adds support for excluding packages when running packages get.

  • very_good packages get -r --ignore=pluginA,pluginB

Closes #636

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

felangel
felangel reviewed Feb 6, 2023
View reviewed changes
lib/src/cli/cli.dart Outdated Show resolved Hide resolved
felangel
felangel reviewed Feb 6, 2023
View reviewed changes
lib/src/cli/cli.dart Outdated Show resolved Hide resolved
@willhlas willhlas marked this pull request as ready for review February 7, 2023 16:54
erickzanardo
erickzanardo previously approved these changes Feb 10, 2023
View reviewed changes
wolfenrain
wolfenrain previously approved these changes Feb 10, 2023
View reviewed changes
renancaraujo
renancaraujo previously approved these changes Feb 10, 2023
View reviewed changes
felangel
felangel suggested changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test to ensure globs are supported?

@willhlas willhlas requested review from felangel and wolfenrain and removed request for felangel and wolfenrain February 13, 2023 16:58
@renancaraujo renancaraujo self-requested a review February 27, 2023 12:32
renancaraujo
renancaraujo previously approved these changes Feb 27, 2023
View reviewed changes
@renancaraujo renancaraujo added the waiting for response Waiting for follow up label Feb 28, 2023
@willhlas willhlas requested review from renancaraujo and removed request for wolfenrain and felangel March 1, 2023 12:36
felangel
felangel previously approved these changes Mar 2, 2023
View reviewed changes
wolfenrain
wolfenrain reviewed Mar 2, 2023
View reviewed changes
lib/src/cli/cli.dart Outdated Show resolved Hide resolved
wolfenrain
wolfenrain reviewed Mar 3, 2023
View reviewed changes
lib/src/cli/cli.dart Outdated Show resolved Hide resolved
willhlas and others added 3 commits March 3, 2023 13:58
@renancaraujo renancaraujo merged commit 3701efa into VeryGoodOpenSource:main Mar 7, 2023
@erickzanardo erickzanardo deleted the feat/exclude-packages branch March 20, 2023 21:27
@renancaraujo renancaraujo mentioned this pull request Mar 23, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renancaraujo renancaraujo renancaraujo approved these changes

@wolfenrain wolfenrain wolfenrain approved these changes

@erickzanardo erickzanardo erickzanardo left review comments

@felangel felangel felangel left review comments

Assignees
No one assigned
Labels
waiting for response Waiting for follow up
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI - feat: support excluding directories
5 participants
@willhlas @erickzanardo @renancaraujo @felangel @wolfenrain