Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: recursive min coverage #647

Merged
merged 14 commits into from
Feb 21, 2023
Merged

fix: recursive min coverage #647

merged 14 commits into from
Feb 21, 2023

Conversation

willhlas
Copy link
Contributor

@willhlas willhlas commented Feb 9, 2023 •
edited by wolfenrain
Loading

Description

Fixes bug where running --min-coverage with --recursive would not throw error if min coverage was not met.

Closes #389

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@willhlas willhlas changed the title Fix/recursive min coverage fix: recursive min coverage Feb 9, 2023
@willhlas willhlas marked this pull request as ready for review February 9, 2023 20:42
wolfenrain
wolfenrain previously approved these changes Feb 9, 2023
View reviewed changes
felangel
felangel suggested changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test for this fix to ensure it doesn't happen again?

renancaraujo
renancaraujo previously approved these changes Feb 16, 2023
View reviewed changes
felangel
felangel previously approved these changes Feb 16, 2023
View reviewed changes
@willhlas willhlas dismissed stale reviews from felangel and renancaraujo via 7e539ac February 17, 2023 17:16
@erickzanardo erickzanardo enabled auto-merge (squash) February 17, 2023 17:20
@erickzanardo erickzanardo merged commit 5f46928 into VeryGoodOpenSource:main Feb 21, 2023
@erickzanardo erickzanardo deleted the fix/recursive-min-coverage branch March 20, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickzanardo erickzanardo erickzanardo approved these changes

@wolfenrain wolfenrain wolfenrain approved these changes

@felangel felangel felangel left review comments

@renancaraujo renancaraujo Awaiting requested review from renancaraujo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: --min-coverage does not work when running with --recursive
5 participants
@willhlas @erickzanardo @renancaraujo @felangel @wolfenrain