fix: allow spaced golden file names #722

alestiago · 2023-04-13T16:41:25Z

Description

Fixes #565. Related to #651 and #720.

✨ New feature (non-breaking change which adds functionality)
🛠️ Bug fix (non-breaking change which fixes an issue)
❌ Breaking change (fix or feature that would cause existing functionality to change)
🧹 Code refactor
✅ Build configuration change
📝 Documentation
🗑️ Chore

alestiago · 2023-04-13T17:44:32Z

I'm expecting #721 (if merged) to be merged before this.

alestiago added 11 commits April 13, 2023 16:36

chore: very_good create

0975d5f

refactor: moved test e2e tests

b198389

refactor: moved e2e create commands

085f11d

refactor: removed e2e tag

b0cd5eb

ci: configured e2e ci

0900a07

chore: removed README.md

e8e5e58

ci: removed tag

1e9e087

chore: removed --set-exit-if-changed

67db691

ci: ammends e2e workflow

a08d403

test: tested spaced golden file name

07d9c68

fix: allow golden spaced test names

f4b4eb2

alestiago self-assigned this Apr 13, 2023

alestiago mentioned this pull request Apr 13, 2023

fix: spaced golden file names #720

Closed

7 tasks

alestiago marked this pull request as ready for review April 13, 2023 16:49

alestiago requested review from felangel, wolfenrain and renancaraujo as code owners April 13, 2023 16:49

renancaraujo previously approved these changes Apr 18, 2023

View reviewed changes

Base automatically changed from refactor/move-e2e-to-own-package to main April 24, 2023 17:11

Merge branch 'main' into fix/allow-spaces-in-golden-files

56c305a

alestiago dismissed renancaraujo’s stale review via 56c305a April 25, 2023 17:04

alestiago requested a review from renancaraujo April 25, 2023 17:04

renancaraujo approved these changes May 2, 2023

View reviewed changes

alestiago merged commit 0e63104 into main May 2, 2023

alestiago deleted the fix/allow-spaces-in-golden-files branch May 2, 2023 16:33