Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: detect licenses locally #883

Merged
merged 25 commits into from
Nov 21, 2023
Merged

Conversation

alestiago
Copy link
Contributor

@alestiago alestiago commented Nov 10, 2023

Status

READY

Description

Instead of fetching, detect license locally. This change uses pana's non-public API intentionally, refer to dart-lang/pana#1277

Now there is no need of a network connection, instead there is a need for a package_config.json (generated on pub get) to know the paths of the cached packages.

There is no public facing API change, instead is an internal implementation change. Hence, there is a small chance that previous detections might differ from current detections.

Demonstration

After the change:

CleanShot.2023-11-17.at.11.13.39.mp4

Before the change:

CleanShot.2023-11-17.at.11.14.10.mp4

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@alestiago alestiago self-assigned this Nov 10, 2023
@alestiago alestiago changed the title feat: detect licenses locally feat!: detect licenses locally Nov 15, 2023
@alestiago alestiago marked this pull request as ready for review November 17, 2023 11:11
@alestiago alestiago requested a review from a team as a code owner November 17, 2023 11:11
@alestiago alestiago merged commit 1c24aee into main Nov 21, 2023
30 checks passed
@alestiago alestiago deleted the alestiago/always-local-license-check branch November 21, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants