-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: detect licenses locally #883
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alestiago
commented
Nov 20, 2023
lib/src/commands/packages/commands/check/commands/licenses.dart
Outdated
Show resolved
Hide resolved
7 tasks
wolfenrain
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Instead of fetching, detect license locally. This change uses pana's non-public API intentionally, refer to dart-lang/pana#1277
Now there is no need of a network connection, instead there is a need for a
package_config.json
(generated onpub get
) to know the paths of the cached packages.There is no public facing API change, instead is an internal implementation change. Hence, there is a small chance that previous detections might differ from current detections.
Demonstration
After the change:
CleanShot.2023-11-17.at.11.13.39.mp4
Before the change:
CleanShot.2023-11-17.at.11.14.10.mp4
Type of Change