Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use relative path instead of absolute when running packages get #919

Merged
merged 13 commits into from
Dec 18, 2023

Conversation

mrgnhnt96
Copy link
Contributor

Status

READY

Description

The change introduced in this PR is to clean up the console when the cwd is printed to console. Specifically when running very_good packages get.
There are times when the full path of the cwd is too long causing the logger to behave unexpectedly.

image

A solution to the problem is to shorten the path printed to console. Instead of printing the absolute path, the relative path is used.

image

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@mrgnhnt96 mrgnhnt96 requested a review from a team as a code owner December 13, 2023 17:01
@mrgnhnt96 mrgnhnt96 changed the title Use relative path instead of absolute when running packages get refactor: Use relative path instead of absolute when running packages get Dec 13, 2023
alestiago
alestiago previously approved these changes Dec 15, 2023
Copy link
Contributor

@alestiago alestiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! Left a minor comments, overall LGTM! 💙

test/src/cli/flutter_cli_test.dart Outdated Show resolved Hide resolved
@alestiago alestiago merged commit af1d059 into VeryGoodOpenSource:main Dec 18, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants