Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Use relative path instead of absolute when running test #920

Merged
merged 7 commits into from
Dec 15, 2023
Merged

refactor: Use relative path instead of absolute when running test #920

merged 7 commits into from
Dec 15, 2023

Conversation

mrgnhnt96
Copy link
Contributor

Fixes: #754

Status

READY

Description

The change introduced in this PR is to clean up the console when the cwd is printed. Specifically when running very_good test.
Sometimes the full path of the cwd is too long and would be cut off. If running recursively, this can leave the developer confused as to which directory was tested.

image

A solution to the problem is to shorten the path printed to console. Instead of printing the absolute path, the relative path is used.

image

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@mrgnhnt96 mrgnhnt96 requested a review from a team as a code owner December 13, 2023 17:22
@mrgnhnt96 mrgnhnt96 changed the title Use relative path instead of absolute when running test refactor: Use relative path instead of absolute when running test Dec 13, 2023
alestiago
alestiago reviewed Dec 14, 2023
View reviewed changes
Copy link
Contributor

@alestiago alestiago left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! I left some very small comments about it, overall LGTM

lib/src/cli/flutter_cli.dart Outdated Show resolved Hide resolved
lib/src/cli/flutter_cli.dart Show resolved Hide resolved
test/src/cli/flutter_cli_test.dart Outdated Show resolved Hide resolved
@alestiago alestiago self-assigned this Dec 14, 2023
@alestiago alestiago added the waiting for response Waiting for follow up label Dec 14, 2023
@mrgnhnt96
Copy link
Contributor Author

Thanks for your review! See the respective changes and lmk if you have any other suggestions!

alestiago
alestiago previously approved these changes Dec 14, 2023
View reviewed changes
@alestiago alestiago removed the waiting for response Waiting for follow up label Dec 14, 2023
wolfenrain
wolfenrain previously approved these changes Dec 14, 2023
View reviewed changes
@mrgnhnt96 mrgnhnt96 dismissed stale reviews from wolfenrain and alestiago via af197e8 December 14, 2023 17:59
@alestiago alestiago merged commit 0670bb0 into VeryGoodOpenSource:main Dec 15, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alestiago alestiago alestiago approved these changes

@wolfenrain wolfenrain wolfenrain left review comments

Assignees

@alestiago alestiago

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: package name not visible in output when run tests recursive
3 participants
@mrgnhnt96 @wolfenrain @alestiago