Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update create flutter_app output text for clarity #922

Merged
merged 10 commits into from Dec 18, 2023

Conversation

yaksh1
Copy link
Contributor

@yaksh1 yaksh1 commented Dec 13, 2023

Resolves #921

Updated CLI template output for
very_good create flutter_app my_app
for more clarity on hoe to open the project.

Created a Very Good App! πŸ¦„

In order to open your project, type:
       $ cd app_name
       $ code .
+----------------------------------------------------+
| Looking for more features?                         |
| We have an enterprise-grade solution for companies |
| called Very Good Start.                            |
|                                                    |
| For more info visit:                               |
| https://verygood.ventures/solution/very-good-start |
+----------------------------------------------------+

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • πŸ› οΈ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • βœ… Build configuration change
  • πŸ“ Documentation
  • πŸ—‘οΈ Chore

@yaksh1 yaksh1 requested a review from a team as a code owner December 13, 2023 20:20
@alestiago alestiago added the feature A new feature or request label Dec 14, 2023
@alestiago alestiago self-assigned this Dec 14, 2023
@alestiago alestiago added the waiting for response Waiting for follow up label Dec 14, 2023
@alestiago alestiago added waiting for response Waiting for follow up and removed waiting for response Waiting for follow up labels Dec 15, 2023
@yaksh1 yaksh1 requested a review from tomarra December 16, 2023 14:38
@alestiago alestiago removed the waiting for response Waiting for follow up label Dec 18, 2023
Copy link
Contributor

@alestiago alestiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I made some amendments to ensure the paths are not using a platform specific separator and included some tests.

This is the output I'm seeing:

@alestiago alestiago removed their assignment Dec 18, 2023
@alestiago alestiago merged commit 0a331de into VeryGoodOpenSource:main Dec 18, 2023
30 checks passed
@alestiago alestiago changed the title docs(cli): Update CLI output text for clarity feat: update create flutter_app output text for clarity Dec 18, 2023
@yaksh1
Copy link
Contributor Author

yaksh1 commented Dec 19, 2023

@alestiago Thank you for these amendments, It was fun working on this. Also, I have some ideas for very_good_cli, if we could discuss it, I would really appreciate it.

@alestiago
Copy link
Contributor

Hi @yaksh1 ! I'm glad you enjoyed working on this. If you have some enhancement ideas for the tool feel free to open an issue for each one of them and we can discuss it there πŸ™Œ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature or request
Projects
Development

Successfully merging this pull request may close these issues.

fix: Updating the CLI template to guide the user towards opening the project after creating
4 participants