Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support 'direct-overridden' dependency type when checking licenses #931

Merged
merged 13 commits into from
Dec 22, 2023

Conversation

alestiago
Copy link
Contributor

@alestiago alestiago commented Dec 19, 2023

Should be merged after #930

Status

READY

Description

Adds support for "direct-overriden" dependency type on very_good packages check licenses --dependency-type 'direct-overridden.

Had to abandon the use of pubspec_lock since the dependency seems to not be maintained any more and overriding it caused the pana score to drop.

Somewhat related to #901

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@alestiago alestiago requested a review from a team as a code owner December 19, 2023 10:33
@alestiago alestiago marked this pull request as draft December 19, 2023 10:34
@alestiago alestiago self-assigned this Dec 19, 2023
Base automatically changed from alestiago/license-dependency-overriden to main December 19, 2023 13:46
@alestiago alestiago marked this pull request as ready for review December 20, 2023 16:32
@alestiago alestiago merged commit 466e0a2 into main Dec 22, 2023
30 checks passed
@alestiago alestiago deleted the alestiago/support-direct-overridden-type branch December 22, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants