Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --dart-define-from-file support #984

Merged

Conversation

macoshita
Copy link
Contributor

@macoshita macoshita commented Feb 29, 2024

Status

READY

Description

Added support for --dart-define-from-file

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • πŸ› οΈ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • βœ… Build configuration change
  • πŸ“ Documentation
  • πŸ—‘οΈ Chore

@macoshita macoshita requested a review from a team as a code owner February 29, 2024 07:02
@macoshita macoshita changed the title Add --dart-define-from-file feat: add --dart-define-from-file Feb 29, 2024
@macoshita macoshita changed the title feat: add --dart-define-from-file feat: add --dart-define-from-file support Feb 29, 2024
@tomarra
Copy link
Contributor

tomarra commented Mar 25, 2024

Hi @macoshita πŸ‘‹ thank you for the contribution! It looks like there is a failure in the analysis step during CI. Can you take a look and fix this before we review?

@macoshita
Copy link
Contributor Author

@tomarra Sorry. I checked analyze, test, etc. as per CONTRIBUTING.md. Please review.

@tomarra tomarra merged commit 9b5c89c into VeryGoodOpenSource:main Apr 4, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants