This repository has been archived by the owner on Feb 21, 2024. It is now read-only.
docs: fixed copy format and command #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrSagarShah
changed the title
MrSagarShah
changed the title
tomarra
reviewed
Jan 25, 2024
README.md
Outdated
| @@ -26,10 +26,10 @@ This template includes a simple demo game with the basics you'll need for game d | |||
| dart pub global activate very_good_cli | |||
| ``` | |||
|
|
|||
| 2. Generate your game | |||
| 2. Generate your game named my_game | |||
There was a problem hiding this comment.
I think we revert this title change and put the comment back in to describe the name parameter. Let's focus the fix on the missing " which is a good catch.
There was a problem hiding this comment.
Hey, @tomarra Thanks.
The only issue I see here is the quick copy button copies the command with a comment.
Generally, I have seen that description with multiple commands like this.
https://github.com/VeryGoodOpenSource/very_good_cli
For a single command and quick start, we should have the command ready for devs to dive in.
#UX Improvement for devs
alestiago
reviewed
Jan 26, 2024
alestiago
reviewed
Jan 26, 2024
alestiago
approved these changes
Jan 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Type of Change