Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove explicitly named libraries #77

Merged
merged 3 commits into from
Feb 28, 2024
Merged

refactor: remove explicitly named libraries #77

merged 3 commits into from
Feb 28, 2024

Conversation

verygoodstefan
Copy link
Contributor

Description

Removing named library from packages to adhere to effective dart guidelines

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • [ X] 🗑️ Chore

luisredondo
luisredondo previously approved these changes Feb 28, 2024
View reviewed changes
@alestiago alestiago added product: very_good_dart_cli Changes that affect the Very Good Dart CLI template. product: very_good_dart_package Changes that affect the Very Good Dart Package template. product: very_good_flutter_package Changes that affect the Very Good Flutter Package template. labels Feb 28, 2024
@alestiago alestiago added the refactor A code change that neither fixes a bug nor add a feature label Feb 28, 2024
@alestiago alestiago changed the title chore: remove named library from Dart & Flutter packages refactor: remove named library from Dart & Flutter packages Feb 28, 2024
@alestiago alestiago changed the title refactor: remove named library from Dart & Flutter packages refactor: remove named libraries Feb 28, 2024
@alestiago alestiago changed the title refactor: remove named libraries refactor: remove explicitly named libraries Feb 28, 2024
@alestiago alestiago merged commit a4b5ce8 into VeryGoodOpenSource:main Feb 28, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alestiago alestiago alestiago approved these changes

@luisredondo luisredondo luisredondo left review comments

Assignees

@alestiago alestiago

@verygoodstefan verygoodstefan

Labels
product: very_good_dart_cli Changes that affect the Very Good Dart CLI template. product: very_good_dart_package Changes that affect the Very Good Dart Package template. product: very_good_flutter_package Changes that affect the Very Good Flutter Package template. refactor A code change that neither fixes a bug nor add a feature
Projects
VGV Open Source 🦄 🧙🌟
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@verygoodstefan @alestiago @luisredondo