Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build error on VS 2022 #117

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

chen3feng
Copy link

Fix #115

@chen3feng
Copy link
Author

I'm also done with the Command Line feature in the process selection list(#116), but it will be pushed as a separated PR.

@CyberShadow
Copy link
Member

I'm also done with the Command Line feature in the process selection list(#116), but it will be pushed as a separated PR.

OK, then I guess you did not intend to include it in this PR.

What about the wine submodule? I don't have the newer commit. Was it an intentional change? If so, please submit a PR to that repository first.

CI (AppVeyor) needs to be green before anything can be merged, so ensuring that CI builds continue working is going to have to be a part of this.

@chen3feng
Copy link
Author

chen3feng commented Aug 15, 2023 via email

@chen3feng
Copy link
Author

chen3feng commented Sep 7, 2023

Hi, I have implemented the feature #116 which show command line and window title in the process list.

image

But I met some problems to make a PR:

I'm using Visual Studio 2022 to build this project, after I open this project, it let me upgrade all vcproj files to 2022, otherwise there are build errors:

C:\Program Files\Microsoft Visual Studio\2022\Professional\MSBuild\Microsoft\VC\v170\Microsoft.CppBuild.targets(456,5): error MSB8020: The build tools for Visual Studio 2010 (Platform Toolset = 'v100') cannot be found. To build using the v100 build tools, please install Visual Studio 2010 build tools.  Alternatively, you may upgrade to the current Visual Studio tools by selecting the Project menu or right-click the solution, and then selecting "Retarget solution".

I tried to download and install the Visual Studio 2010 build tools, but it is already outdated, MS doesn't provide it.

I can upgrade submodules which are belong to VerySleepy, but wxWidgets is not a part of VerySleep project, if I upgrade them to VS 2022 projects, I don't know how to issue a PR to them.

Even if I only fix this build error, I also met this problem.

@CyberShadow
Copy link
Member

Sorry, I don't know how to help you here, except for two things:

  1. The build works in AppVeyor, I'm not sure but maybe it would be worth trying to replicate that known-working build environment.

  2. I can upgrade submodules which are belong to VerySleepy, but wxWidgets is not a part of VerySleep project, if I upgrade them to VS 2022 projects, I don't know how to issue a PR to them.

    Maybe check if a newer wxWidgets version is available which does have the right project files, in which case upgrading the wxWidgets version used by Very Sleepy would make sense. If not, you could also place the upgraded project files in the Very Sleepy repository, outside the wxWidgets submodule.

@chen3feng
Copy link
Author

I can't make any progress on this issue due to this blocking issue, anyone can help me?

Here is some more information, FYI:

https://developercommunity.visualstudio.com/t/windowstargetplatformversion-makes-it-impossible-t/140294

@chen3feng
Copy link
Author

Maybe I don't make any changes on the VS version, disregard my local build, just make the CI happy?

@top-master
Copy link

top-master commented Apr 28, 2024

"don't make any changes on the VS version"

Many projects meet those issues, since VS build-system tries real hard to be incompatible, but you shouldn't let that discourage you:

  • Migrate to CMake,
  • but combine CMake with own build.bat instead of requiring generation of VS projects.
  • Finally, IDEs like Qt-Creator can debug any .exe, without need for .pro file (without need for Qt project file being open or even exist).

Or even without CMake:

  • Simply create build-tools sub-folder (or just build) for this repo.
  • Place in said folder yet more sub-folders, one for each VS version, like vs2010 folder.
  • This is possible only since VS project files support the ".." (relative file paths).

"Visual Studio 2010 ... MS doesn't provide it."

Internet has many unofficial backups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Many "Can't open include file" errors when build dbghelpw
3 participants