Added Components, Links, Styling and Rearrange files #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jeromehardaway
approved these changes
Aug 20, 2022
andrew-t-james
requested changes
Aug 20, 2022
andrew-t-james
requested changes
Aug 20, 2022
| import React from 'react' | ||
| import { useRouter } from 'next/router' | ||
| import CheckCircle from '../../images/check-circle.png' | ||
| import '../../assets/css/resumebuilder.css' |
There was a problem hiding this comment.
This is global. I think these import statements could be dropped.
| @@ -1,5 +1,7 @@ | |||
| import React from 'react' | |||
| import { useRouter } from 'next/router' | |||
| import '../../assets/css/resumebuilder.css' | |||
There was a problem hiding this comment.
I'm not sure what you mean by, '+1 on import statement'
…older, place components in individual folder, updated _app.js
Cameron-Porter
approved these changes
Aug 25, 2022
…d more links with proper path names
andrew-t-james
requested changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The following changes were made:
Moved images for the Resume Builder (RB) to the main src file
Added the following files within the Resume-Builder Component Folder
Created a CSS folder for the resume builder within the main CSS folder. This folder has all the styling for the different components. I wanted to try to mimic how the other CSS files were so I created a sort of main hub for the RB styling called resumebuilder.css and this imports all of the styling for the components and within
../css/index.jsit is imported.Added styling for the landing and confirmation components. The styling is not final, it will need to be looked over to pull some preexisting styling from the main app
Added a link in the Nav components so we can access the RB from there - the path is /resume-builder
Landing.js name was changed to resume-builder.js to match the path from the link, especially since this will be the first page people will see when the link is clicked.
Related Issue
How Has This Been Tested?
To test to see components on screen I added a link in the Nav, however, when testing I was met with a 404: This page could not be found. (See attached screenshot) Unsure of what the issue could be.
Types of changes
Checklist: