Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

omit_norms was deprecated #69

Closed
lukas-vlcek opened this issue Nov 24, 2017 · 3 comments
Closed

omit_norms was deprecated #69

lukas-vlcek opened this issue Nov 24, 2017 · 3 comments
Labels
ES 2.x

Comments

@lukas-vlcek
Copy link
Member

lukas-vlcek commented Nov 24, 2017 •
edited
Loading

See comment below for details.
lukas-vlcek added a commit to lukas-vlcek/elasticsearch-templates that referenced this issue Nov 24, 2017
@lukas-vlcek
WIP, Upgrade to ES 5.x
df59b12 
Should fix: ViaQ#67, ViaQ#68, ViaQ#69
@lukas-vlcek lukas-vlcek mentioned this issue Nov 24, 2017
Merged
lukas-vlcek added a commit to lukas-vlcek/elasticsearch-templates that referenced this issue Nov 28, 2017
@lukas-vlcek
WIP, Support multiple ES versions
e6bffe1 
Closes: ViaQ#71
Should fix: ViaQ#67, ViaQ#68, ViaQ#69
lukas-vlcek added a commit to lukas-vlcek/elasticsearch-templates that referenced this issue Nov 28, 2017
@lukas-vlcek
WIP, Support multiple ES versions
2738062 
- Added CI tests via Travis service

Closes: ViaQ#71
Should fix: ViaQ#67, ViaQ#68, ViaQ#69
lukas-vlcek added a commit to lukas-vlcek/elasticsearch-templates that referenced this issue Nov 28, 2017
@lukas-vlcek
WIP, Support multiple ES versions
2584489 
- Added CI tests via Travis service

Closes: ViaQ#71
Should fix: ViaQ#67, ViaQ#68, ViaQ#69
lukas-vlcek added a commit to lukas-vlcek/elasticsearch-templates that referenced this issue Nov 28, 2017
@lukas-vlcek
WIP, Support multiple ES versions
eb5dc50 
- Added CI tests via Travis service

Closes: ViaQ#71
Should fix: ViaQ#67, ViaQ#68, ViaQ#69
lukas-vlcek added a commit to lukas-vlcek/elasticsearch-templates that referenced this issue Nov 28, 2017
@lukas-vlcek
WIP, Support multiple ES versions
16ccd70 
- Added CI tests via Travis service

Closes: ViaQ#71
Should fix: ViaQ#67, ViaQ#68, ViaQ#69
lukas-vlcek added a commit to lukas-vlcek/elasticsearch-templates that referenced this issue Nov 30, 2017
@lukas-vlcek
WIP, Support multiple ES versions
fa1e1e7 
- Added CI tests via Travis service

Closes: ViaQ#71
Should fix: ViaQ#67, ViaQ#68, ViaQ#69
lukas-vlcek added a commit to lukas-vlcek/elasticsearch-templates that referenced this issue Dec 7, 2017
@lukas-vlcek
WIP, Support multiple ES versions
968be2e 
- Added CI tests via Travis service

Closes: ViaQ#71
Should fix: ViaQ#67, ViaQ#68, ViaQ#69
lukas-vlcek added a commit to lukas-vlcek/elasticsearch-templates that referenced this issue Dec 7, 2017
@lukas-vlcek
WIP, Support multiple ES versions
e2e68b4 
- Added CI tests via Travis service

Closes: ViaQ#71
Should fix: ViaQ#67, ViaQ#68, ViaQ#69
@lukas-vlcek
Copy link
Member Author

lukas-vlcek commented Dec 12, 2017 •
edited
Loading

It turns out we are still using omit_norms in mappings for ES 2.x as well, while we should not be. Hence adding ES 2.x label as well.

Namely in skeleton.json here and here.

It seems that omit_norms was last used in official documentation in ES 1.3 but starting with ES 1.4 it was changed to norms (specifically to {"norms":{"enabled": true/false}}). Unfortunately, release notes were not released prior to ES 2.x so we would need to find specific commit to track this change precisely.

With ES 2.x it seems that norms are configured consistently like {"norms":{"enabled": true/false}}. See doc for 2.0, 2.1, 2.2, 2.3 and 2.4.

@lukas-vlcek
Copy link
Member Author

After further inspection I think this should be viewed as ES 2.x specific issue only given it has to be addressed before Upgrade to ES 5.x.

lukas-vlcek added a commit to lukas-vlcek/elasticsearch-templates that referenced this issue Dec 13, 2017
@lukas-vlcek
omit_norms was deprecated
de085fe 
Closes ViaQ#69
@lukas-vlcek lukas-vlcek mentioned this issue Dec 13, 2017
Merged
@richm richm closed this as completed in #74 Dec 13, 2017
lukas-vlcek added a commit to lukas-vlcek/elasticsearch-templates that referenced this issue Dec 13, 2017
@lukas-vlcek
WIP, Support multiple ES versions
9354adb 
- Added CI tests via Travis service

Closes: ViaQ#71
Should fix: ViaQ#67, ViaQ#68, ViaQ#69
@lukas-vlcek
Copy link
Member Author

@richm I need a new release of index_templates. As of writing the most recent one is 0.0.12 and that release did not include this fix (ie. it is still using omit_norms).

This is causing failed tests of comparison of generated index_templates vs downloaded index_templates in #71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ES 2.x
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lukas-vlcek