Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: Add static.Logger() so new code can use non-static patterns. #27

Closed
wants to merge 1 commit into from

Conversation

alanconway
Copy link
Member

Add static.Logger() so that the static logger can be passed as an argument.
Allows old code using the static log pattern to be extended with new code using log argument passing.

Add static.Logger() so that the static logger can be passed as an
argument. Allows old code using the static log pattern to be extended
with new code using log argument passing.
@xperimental
Copy link
Contributor

I'm not sure if we should add this, need to think about this a bit.

In a pinch you can already use the return value of V(0) to get a copy of the static logger instance.

@alanconway
Copy link
Member Author

/close
static.V(0) is equivalent to the proposed static.Logger() so no need for this.

@openshift-ci openshift-ci bot closed this Jul 15, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jul 15, 2022

@alanconway: Closed this PR.

In response to this:

/close
static.V(0) is equivalent to the proposed static.Logger() so no need for this.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alanconway alanconway deleted the static-logger branch July 15, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants