Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOG-4811: Fluentd is unable to forward logs to external ipv6 elasticsearch instance #106

Merged
merged 1 commit into from Nov 15, 2023

Conversation

Clee2691
Copy link

Description

This is a forward port of #105.

Summary:

This PR fixes support for host/hosts placeholders specifically for ipv6 addresses.
Before this fix, IPv6 addresses would not be parsed correctly after evaluating host/hosts for placeholders.

/cc @cahartma
/assign @jcantrill

Links

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 14, 2023

@Clee2691: This pull request references LOG-4811 which is a valid jira issue.

In response to this:

Description

This is a forward port of #105.

Summary:

This PR fixes support for host/hosts placeholders specifically for ipv6 addresses.
Before this fix, IPv6 addresses would not be parsed correctly after evaluating host/hosts for placeholders.

/cc @cahartma
/assign @jcantrill

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from cahartma November 14, 2023 20:03
@jcantrill
Copy link
Member

You will also need something like this:

mv /usr/share/gems/fluent-plugin-detect-exceptions.source0001.patch /usr/share/gems/gems/fluent-plugin-detect-exceptions-*/ && \

@Clee2691
Copy link
Author

/retest

@jcantrill
Copy link
Member

/approve

@Clee2691 once merged please make sure to also do a midstream PR to address the dockerfile change

Copy link
Contributor

openshift-ci bot commented Nov 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Clee2691, jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jcantrill
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 15, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit fb62777 into ViaQ:v1.16.x Nov 15, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants