Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LOG-2565: Upgrade ruby, fluent and dependencies #32

Merged
merged 2 commits into from
May 10, 2022
Merged

LOG-2565: Upgrade ruby, fluent and dependencies #32

merged 2 commits into from
May 10, 2022

Conversation

jcantrill
Copy link
Member

@jcantrill jcantrill commented Apr 14, 2022 •
edited

Description

This PR:

  • updates ruby to v2.7
  • updates fluentd to 1.14.6
  • updates all dependencies to latest

/hold

https://issues.redhat.com/browse/LOG-2565

@jcantrill jcantrill mentioned this pull request May 3, 2022
Merged
@syedriko
Copy link
Contributor

syedriko commented May 4, 2022 •
edited

@jcantrill

Dockerfile.unit
9:RUN gem install rake:13.0.6 bundler:2.2.33 --no-ri --no-doc

Since 2.6, gem install --no-ri and --no-doc have been deprecated https://www.ruby-lang.org/en/news/2018/12/25/ruby-2-6-0-released. That's what fails in the ruby 2.7 CI PR, we run this In Dockerfile.unit.
Also, "Bundler is now installed as a default gem", so chances are, we don't need to install it.

@jcantrill
Copy link
Member Author

/retest

@jcantrill jcantrill changed the base branch from main to ruby27-v1.14.x May 4, 2022 18:09
@jcantrill
Copy link
Member Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jcantrill jcantrill changed the title Upgrade ruby, fluent and dependencies LOG-2565: Upgrade ruby, fluent and dependencies May 4, 2022
@jcantrill
Copy link
Member Author

/hold cancel

@syedriko
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 10, 2022
@syedriko syedriko merged commit 8bba164 into ViaQ:ruby27-v1.14.x May 10, 2022
@jcantrill jcantrill deleted the upgrade_fluent branch May 10, 2022 16:54
@jcantrill
Copy link
Member Author

/cherrypick main

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 10, 2022
Merged
@openshift-cherrypick-robot
Copy link

@jcantrill: new pull request created: #33

In response to this:

/cherrypick main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahartma cahartma Awaiting requested review from cahartma

@Pranjal-Gupta2 Pranjal-Gupta2 Awaiting requested review from Pranjal-Gupta2

Assignees

@syedriko syedriko

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
3 participants
@jcantrill @syedriko @openshift-cherrypick-robot