-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logging OMC Addon - Helm version #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Demo now doesn't care about local logs - Multi Cluster Logging chart doesn't install policies for spoke cluster - AddOn chart now install OpenShift Logging operator
periklis
approved these changes
Sep 20, 2023
periklis
approved these changes
Sep 21, 2023
periklis
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/LOG-4288
In this PR we introduce the base code of an OMC AddOn that configures
ClusterLogForwarder
to push logs to a URL using mTLS authentication. Currently, AddOn assumes that the hub Loki runs on the hub cluster on theopenshift-logging
namespace. The AddOn is also not responsible for generating any certificates and simply expects certain secrets to already exist, namely, it assumes that there is an mTLS secret created under the namespace of each spoke cluster with the same name as the spoke cluster and that a ConfigMap for the Loki gateway CA bundle exists underopenshift-monitoring
. The URL will be fetched from anAddOnDeploymentConfig
resource that should live under the spoke cluster namespace. All configuration resources for the AddOn can be viewed in theManagedClusterAddOn
andClusterManagementAddOn
. The AddOn will then template a helm chart with these values to generate a set of manifests to be deployed to the spoke cluster, namely, it will deploy aSecret
andClusterLogForwarder
Note to reviewers
Under
demo/
there is a README with instructions on how to install/configure RHACM and install and test the AddOn.How to check if the AddOn is working correctly
Issues
ClusterLogForwarder.Spec.Outputs.TLS.InsecureSkipVerify
totrue
because of theCommonName
in the Loki Gateway Certificate it has the dnsName of the gateway service which then when the spoke collectors are verifying the hub certificate they will find a mismatch in the Hostname resulting in the errorHostname mismatch
Improvements