Skip to content
This repository has been archived by the owner on Apr 25, 2022. It is now read-only.

Log 1894: Updating Loki Operand to 2.4.1 #106

Merged
merged 8 commits into from
Dec 7, 2021

Conversation

Red-GV
Copy link
Contributor

@Red-GV Red-GV commented Nov 24, 2021

This PR does the following:

  • Updates to Loki Operand to the 2.4.1 image
  • Enables the WAL capabilities and disables the handover mechanism
  • Adds the Index Gateway component
  • Converts Queriers from a StatefulSet to a Deployment

The ingesters must remain as a statefulset in order to use WAL.

JIRA: https://issues.redhat.com/browse/LOG-1894

@Red-GV Red-GV marked this pull request as draft November 24, 2021 22:00
Copy link
Contributor

@periklis periklis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! 🚀 A couple of small improvements and we are set to go:

  1. Please vet that we using explicitly the new defaults if we don't override them in Loki config or limits config (https://github.com/grafana/loki/blob/main/docs/sources/upgrading/_index.md#change-of-some-default-limits-to-common-values)
  2. Same for configuration defaults (https://github.com/grafana/loki/blob/main/docs/sources/upgrading/_index.md#change-of-configuration-defaults)
  3. Although we use the FIFO cache since the early beginning please vet that the configuration makes explicit usage of its configuration params (https://github.com/grafana/loki/blob/main/docs/sources/upgrading/_index.md#in-memory-fifo-caches-enabled-by-default)
  4. Same for the ingester lifecycle final_sleep param (https://github.com/grafana/loki/blob/main/docs/sources/upgrading/_index.md#ingester-lifecycler-final_sleep-now-defaults-to-0s)
  5. Same for memberlist https://github.com/grafana/loki/blob/main/docs/sources/upgrading/_index.md#memberlist-config-now-automatically-applies-to-all-non-configured-rings
  6. Same for GRPC server settings https://github.com/grafana/loki/blob/main/docs/sources/upgrading/_index.md#changed-defaults-for-some-grpc-server-settings

Making the above explicit in the loki configuration enables faster lookup while troubleshooting.

internal/manifests/internal/config/options.go Outdated Show resolved Hide resolved
internal/manifests/internal/sizes.go Outdated Show resolved Hide resolved
internal/manifests/internal/sizes.go Show resolved Hide resolved
internal/manifests/querier.go Outdated Show resolved Hide resolved
internal/manifests/service_monitor.go Outdated Show resolved Hide resolved
internal/manifests/var.go Outdated Show resolved Hide resolved
@Red-GV Red-GV force-pushed the log-1894-loki-upgrades branch 2 times, most recently from c051cf1 to c41042d Compare November 29, 2021 21:13
@Red-GV Red-GV marked this pull request as ready for review November 30, 2021 23:02
api/v1beta1/lokistack_types.go Outdated Show resolved Hide resolved
api/v1beta1/lokistack_types.go Outdated Show resolved Hide resolved
internal/manifests/config.go Outdated Show resolved Hide resolved
internal/manifests/var.go Outdated Show resolved Hide resolved
api/v1beta1/lokistack_types.go Outdated Show resolved Hide resolved
internal/manifests/internal/sizes.go Show resolved Hide resolved
Copy link
Contributor

@periklis periklis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@periklis periklis merged commit 91d6601 into ViaQ:master Dec 7, 2021
@Red-GV Red-GV deleted the log-1894-loki-upgrades branch January 25, 2022 19:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants