This repository has been archived by the owner on Apr 25, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 11
Log 1894: Updating Loki Operand to 2.4.1 #106
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
periklis
reviewed
Nov 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! 🚀 A couple of small improvements and we are set to go:
- Please vet that we using explicitly the new defaults if we don't override them in Loki config or limits config (https://github.com/grafana/loki/blob/main/docs/sources/upgrading/_index.md#change-of-some-default-limits-to-common-values)
- Same for configuration defaults (https://github.com/grafana/loki/blob/main/docs/sources/upgrading/_index.md#change-of-configuration-defaults)
- Although we use the FIFO cache since the early beginning please vet that the configuration makes explicit usage of its configuration params (https://github.com/grafana/loki/blob/main/docs/sources/upgrading/_index.md#in-memory-fifo-caches-enabled-by-default)
- Same for the ingester lifecycle
final_sleep
param (https://github.com/grafana/loki/blob/main/docs/sources/upgrading/_index.md#ingester-lifecycler-final_sleep-now-defaults-to-0s) - Same for memberlist https://github.com/grafana/loki/blob/main/docs/sources/upgrading/_index.md#memberlist-config-now-automatically-applies-to-all-non-configured-rings
- Same for GRPC server settings https://github.com/grafana/loki/blob/main/docs/sources/upgrading/_index.md#changed-defaults-for-some-grpc-server-settings
Making the above explicit in the loki configuration enables faster lookup while troubleshooting.
c051cf1
to
c41042d
Compare
c41042d
to
5f605c6
Compare
sasagarw
suggested changes
Dec 2, 2021
periklis
reviewed
Dec 6, 2021
f88a4f9
to
987d96a
Compare
periklis
reviewed
Dec 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sasagarw
approved these changes
Dec 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
The ingesters must remain as a statefulset in order to use WAL.
JIRA: https://issues.redhat.com/browse/LOG-1894