Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data-point): Define accumulator.locals with a plain object #254

Merged
merged 2 commits into from
Apr 4, 2018

Conversation

raingerber
Copy link
Contributor

What: Define accumulator.locals with a plain object

Why: Just to simplify the code a bit.

How: Removes the Locals function and uses a plain object instead.

Checklist:

  • Has Breaking changes
  • Documentation
  • Tests
  • Ready to be merged

@raingerber raingerber self-assigned this Mar 30, 2018
@codecov
Copy link

codecov bot commented Mar 30, 2018

Codecov Report

Merging #254 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #254   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         129    128    -1     
  Lines        1704   1698    -6     
  Branches      144    144           
=====================================
- Hits         1704   1698    -6
Impacted Files Coverage Δ
packages/data-point/lib/accumulator/factory.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd10bf6...0918da4. Read the comment docs.

@acatl acatl merged commit a379930 into ViacomInc:master Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants