docs(guidelines): improve contribution guidelines #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change templates + force codemods on breaking changes
CONTRIBUTING.md
Outdated
| data-point-codemods that will help users upgrade their codebase. | ||
|
|
||
| Breaking changes without a codemod will not be accepted unless a codemod is not | ||
| viable or does not apply to the specific situation. |
There was a problem hiding this comment.
A couple of lines have hard line breaks but other longer lines don't. Can we make them consistent?
| @@ -0,0 +1,38 @@ | |||
| const Util = require('util') | |||
There was a problem hiding this comment.
This file seems irrelevant to the PR.
paulmolluzzo
requested changes
Jan 24, 2018
|
@paulmolluzzo addressed your feedback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change templates + force codemods on breaking changes
What: change github templates format + contribution.md ask developers to send codemods when breaking changes
Why: improve quality of issues and pullrequest
How: changing templates
Checklist: