Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(data-point/base-entity): Test that entity methods are executed in order #208

Merged
merged 2 commits into from
Feb 14, 2018

Conversation

raingerber
Copy link
Contributor

What: Test that middleware + entity lifecycle methods are executed in the correct order.

Why: I don't think this is being tested now.

How: Uses acc.locals to pass in lifecycle methods that use the same scope as the middleware that's being used.

  • Has Breaking changes
  • Documentation
  • Tests
  • Ready to be merged

@raingerber raingerber self-assigned this Feb 6, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 437baf5 on raingerber:test-lifecycle-execution-order into fdfdc49 on ViacomInc:master.

@coveralls
Copy link

coveralls commented Feb 6, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 5d1857a on raingerber:test-lifecycle-execution-order into 1a80a47 on ViacomInc:master.

Copy link
Collaborator

@paulmolluzzo paulmolluzzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So awesome! 🙌 🙌 🙌

@acatl acatl merged commit e3a03c3 into ViacomInc:master Feb 14, 2018
victorsingh pushed a commit to victorsingh/data-point that referenced this pull request Feb 15, 2018
@raingerber raingerber deleted the test-lifecycle-execution-order branch February 18, 2018 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants