docs(data-point/readme): Replace the term TransformOptions with the word Object #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulmolluzzo
approved these changes
Feb 13, 2018
| @@ -316,7 +316,7 @@ This method will return a **Promise** if `done` is omitted. | |||
| | *options* | [Reducer](#reducers) | Request options. See this [example](#options-with-constants) for using constants in the reducer | | |||
| | *done* | `function` _(optional)_ | Error-first callback [Node.js style callback](https://nodejs.org/api/errors.html#errors_node_js_style_callbacks) that has the arguments `(error, result)`, where `result` contains the final resolved [Accumulator](#accumulator). The actual transformation result will be inside the `result.value` property. | | |||
|
|
|||
| **<a name="transform-options">TransformOptions</a>** | |||
| **<a name="transform-options">Options</a>** | |||
There was a problem hiding this comment.
It's not visible, but do we also want to change the name?
There was a problem hiding this comment.
I could change it, just not sure what a better name would be (since options is probably too generic)
acatl
approved these changes
Feb 14, 2018
victorsingh
pushed a commit
to victorsingh/data-point
that referenced
this pull request
Feb 15, 2018
Replace the term TransformOptions with the word Object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Removes the term
TransformOptionsfrom the readme (closes #200)Why: It makes the readme more clear.
Checklist: